8388793: Convert test/jdk/java/foreign tests to use JUnit - #32042
Draft
JornVernee wants to merge 5 commits into
Draft
8388793: Convert test/jdk/java/foreign tests to use JUnit#32042JornVernee wants to merge 5 commits into
JornVernee wants to merge 5 commits into
Conversation
|
👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@JornVernee The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is carefully arranged into 4 different commits:
assertThrowsto use static imports like the other asserts (1fafd58)assertThrowsto cover only the lines that are actually expected to throw. I felt that his was needed to make some of the changes more 'sane', instead of just having theassertThrowscover the entire method body. (80d4b52)It's probably easiest to review the individual commits. (1) and (2) and (4) are fairly mechanical changes, so the interesting thing to look at is (3).
Depends on: #32014
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32042/head:pull/32042$ git checkout pull/32042Update a local copy of the PR:
$ git checkout pull/32042$ git pull https://git.openjdk.org/jdk.git pull/32042/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 32042View PR using the GUI difftool:
$ git pr show -t 32042Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32042.diff